Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(ios): update requirements & support table #1388

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erisu
Copy link
Member

@erisu erisu commented Dec 26, 2024

Motivation and Context

Update documentation for cordova-ios@8.0.0

Description

Updated requirements & support table

Testing

n/a

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu marked this pull request as draft December 26, 2024 05:55
<ul>
<li>Cocoapods: >=1.16.0</li>
<li>ios-deploy: >=1.12.2</li>
<li>Node: >=16.13.0</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our intention is to target NodeJS 18? But that would put us out of sync with the rest of the Cordova tooling... but I also don't want to delay the iOS release until we're ready to depend on 20 for everything 😕

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep it at >=16.13.0 for now...

Maybe in April/May we could bump the packages to >=20?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of testing, I think we already upgraded to packages that only support NodeJS 18+ in cordova-ios and we're not testing 16.x in CI anymore, so I don't want to promise 16 support if we aren't actually making sure that it works.

I'd rather go with 18 as a minimum, or make a decision to use 20 (and then avoid another major bump when we bump the tooling?)

Copy link
Member Author

@erisu erisu Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then lets go with >=20.5.0...

I would suggest to create the vote on the dev mailing list, since it would be deprecating 18.x while it is still supported/active by Node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants